Support service correlation for mirroring spans

sanket-mundra commented 10 months ago

Description

BREAKING CHANGE: Added a new state store in raw-spans-grouper: peer-identity-to-span-metadata-store

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (70faf7e) 79.88% compared to head (0912315) 79.53%. Report is 32 commits behind head on main.

:exclamation: Current head 0912315 differs from pull request most recent head 3a217cf. Consider uploading reports for the commit 3a217cf to get more accurate results

Files	Patch %	Lines
...cher/enrichment/clients/DefaultClientRegistry.java	0.00%	37 Missing :warning:
.../trace/reader/attributes/DefaultValueResolver.java	54.76%	15 Missing and 4 partials :warning:
...rtrace/core/rawspansgrouper/RawSpansProcessor.java	87.70%	4 Missing and 11 partials :warning:
...race/core/rawspansgrouper/TraceEmitPunctuator.java	76.47%	9 Missing and 3 partials :warning:
...rawspansgrouper/validator/IpIdentityValidator.java	0.00%	3 Missing and 2 partials :warning:
...e/core/spannormalizer/rawspan/ByPassPredicate.java	28.57%	2 Missing and 3 partials :warning:
.../accessor/entities/TraceEntityAccessorBuilder.java	0.00%	4 Missing :warning:
.../accessor/entities/DefaultTraceEntityAccessor.java	93.02%	1 Missing and 2 partials :warning:
...wspansgrouper/validator/PeerIdentityValidator.java	40.00%	2 Missing and 1 partial :warning:
...nrichedspan/constants/utils/EnrichedSpanUtils.java	66.66%	1 Missing :warning:
... and 2 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #431 +/- ## ============================================ - Coverage 79.88% 79.53% -0.36% - Complexity 1419 1427 +8 ============================================ Files 128 130 +2 Lines 5569 5692 +123 Branches 512 533 +21 ============================================ + Hits 4449 4527 +78 - Misses 884 912 +28 - Partials 236 253 +17 ``` | [Flag](https://app.codecov.io/gh/hypertrace/hypertrace-ingester/pull/431/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/hypertrace/hypertrace-ingester/pull/431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace) | `79.53% <72.75%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

Unit Test Results

  79 files +1   79 suites +1 1m 50s :stopwatch: +5s 419 tests +1 419 :heavy_check_mark: +1 0 :zzz: ±0 0 :x: ±0

Results for commit 95d5ea01. ± Comparison against base commit 7b5ec6c2.

github-actions[bot] commented 10 months ago

Unit Test Results

  79 files +1   79 suites +1 1m 27s :stopwatch: -18s 420 tests +2 420 :heavy_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 25bcf219. ± Comparison against base commit 7b5ec6c2.

github-actions[bot] commented 10 months ago

Unit Test Results

  79 files +1   79 suites +1 1m 39s :stopwatch: -6s 420 tests +2 420 :heavy_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit c7885741. ± Comparison against base commit 7b5ec6c2.