hypertrace / hypertrace-ingester

Streaming jobs for Hypertrace
Other
13 stars 16 forks source link

remove rx in entity span enricher resolution #439

Closed kishansairam9 closed 9 months ago

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 20s :stopwatch: -23s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 928e3c9e. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 21s :stopwatch: -22s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit f73ee36c. ± Comparison against base commit 8124224a.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (1aea26b) 79.93% compared to head (9cf9b34) 79.87%.

Files Patch % Lines
.../trace/reader/attributes/DefaultValueResolver.java 54.76% 15 Missing and 4 partials :warning:
...cher/enrichment/clients/DefaultClientRegistry.java 0.00% 7 Missing :warning:
.../accessor/entities/DefaultTraceEntityAccessor.java 92.10% 1 Missing and 2 partials :warning:
...ace/accessor/entities/AttributeValueConverter.java 87.50% 1 Missing :warning:
.../accessor/entities/TraceEntityAccessorBuilder.java 0.00% 1 Missing :warning:
...reader/attributes/DefaultTraceAttributeReader.java 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #439 +/- ## ============================================ - Coverage 79.93% 79.87% -0.06% + Complexity 1421 1413 -8 ============================================ Files 128 127 -1 Lines 5566 5551 -15 Branches 509 515 +6 ============================================ - Hits 4449 4434 -15 + Misses 885 879 -6 - Partials 232 238 +6 ``` | [Flag](https://app.codecov.io/gh/hypertrace/hypertrace-ingester/pull/439/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/hypertrace/hypertrace-ingester/pull/439/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace) | `79.87% <68.93%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 19s :stopwatch: -24s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 1d2bd838. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 20s :stopwatch: -23s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 31859dd2. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 19s :stopwatch: -24s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 202a4723. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 19s :stopwatch: -24s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cdebeb3f. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 19s :stopwatch: -24s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 9645b320. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 20s :stopwatch: -23s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 0015a601. ± Comparison against base commit 8124224a.

kishansairam9 commented 9 months ago

Blocked on fixing gradle issue on consuming attribute service which has ht bom. Looks like we need to migrate to gradle 8+ at least for fix if not complete bom, but if we're doing that might as well take care of bom

cc @mihirgt

aaron-steinfeld commented 9 months ago

Blocked on fixing gradle issue on consuming attribute service which has ht bom. Looks like we need to migrate to gradle 8+ at least for fix if not complete bom, but if we're doing that might as well take care of bom

cc @mihirgt

Even if we want to the bom now, I'd do gradle 8 first anyway. That should only take a few min.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 6s :stopwatch: -37s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit b4c662c5. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 8s :stopwatch: -35s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 86cc2c20. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 9s :stopwatch: -34s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 2e9c7532. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 5s :stopwatch: -38s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 85edd1a0. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 8s :stopwatch: -35s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 1a81ef45. ± Comparison against base commit 8124224a.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 5s :stopwatch: -1s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit c476735f. ± Comparison against base commit a335c7fc.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 7s :stopwatch: -1s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 56124538. ± Comparison against base commit 1aea26b7.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 5s :stopwatch: -3s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 8213a79b. ± Comparison against base commit 1aea26b7.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 3s :stopwatch: -5s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 78cb34e2. ± Comparison against base commit 1aea26b7.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 4s :stopwatch: -4s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit b8486b2c. ± Comparison against base commit 1aea26b7.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 3s :stopwatch: -5s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 7566d8f2. ± Comparison against base commit 1aea26b7.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 3s :stopwatch: -5s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 9cf9b346. ± Comparison against base commit 1aea26b7.

github-actions[bot] commented 9 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 3s :stopwatch: -5s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit f33576d2. ± Comparison against base commit 1aea26b7.