hypertrace / hypertrace-ingester

Streaming jobs for Hypertrace
Other
13 stars 16 forks source link

fix: re-registring of cache metrics #454

Closed kotharironak closed 6 months ago

kotharironak commented 6 months ago

As part of my previous PR: https://github.com/hypertrace/hypertrace-ingester/pull/453, I assumed that the api registerCacheTrackingOccupancy only register max cache size gauge metrics. But, as pointed out in PR comment, it also register input cache for metrics.

As part of this PR, addressing the comment of registration of same cache twice.

github-actions[bot] commented 6 months ago

Unit Test Results

  79 files  ±0    79 suites  ±0   1m 11s :stopwatch: +4s 421 tests ±0  421 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 7863a9fa. ± Comparison against base commit 01567e34.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (01567e3) 79.62% compared to head (7863a9f) 79.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #454 +/- ## ============================================ - Coverage 79.62% 79.58% -0.05% + Complexity 1435 1431 -4 ============================================ Files 130 130 Lines 5709 5697 -12 Branches 533 533 ============================================ - Hits 4546 4534 -12 Misses 911 911 Partials 252 252 ``` | [Flag](https://app.codecov.io/gh/hypertrace/hypertrace-ingester/pull/454/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/hypertrace/hypertrace-ingester/pull/454/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace) | `79.58% <100.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 months ago

Unit Test Results

  79 files  ±0    79 suites  ±0   1m 9s :stopwatch: +2s 421 tests ±0  421 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit a3263ca2. ± Comparison against base commit 01567e34.