remove self correlation and default value

sanket-mundra commented 5 months ago

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

github-actions[bot] commented 5 months ago

Unit Test Results

  79 files ±0   79 suites ±0 1m 4s :stopwatch: -1s 421 tests ±0 421 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit 44f600d4. ± Comparison against base commit d0e409fa.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 79.50%. Comparing base (d0e409f) to head (44f600d).

Files	Patch %	Lines
...rawspansgrouper/validator/IpIdentityValidator.java	0.00%	6 Missing and 2 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #457 +/- ## ============================================ - Coverage 79.59% 79.50% -0.09% Complexity 1431 1431 ============================================ Files 130 130 Lines 5704 5710 +6 Branches 533 539 +6 ============================================ Hits 4540 4540 - Misses 912 917 +5 - Partials 252 253 +1 ``` | [Flag](https://app.codecov.io/gh/hypertrace/hypertrace-ingester/pull/457/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/hypertrace/hypertrace-ingester/pull/457/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace) | `79.50% <0.00%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hypertrace#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sanket-mundra commented 5 months ago

Couldn't find a better way to do it.

hypertrace / hypertrace-ingester