hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

feat: CreateCsvDownloaderService #2367

Closed palbizu closed 1 year ago

palbizu commented 1 year ago

Description

Adding Create CSV Downloader Service

Testing

Locally tested

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2367 (d804365) into main (f4ae953) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
+ Coverage   82.93%   82.95%   +0.02%     
==========================================
  Files         920      921       +1     
  Lines       20493    20522      +29     
  Branches     3223     3227       +4     
==========================================
+ Hits        16995    17024      +29     
  Misses       3376     3376              
  Partials      122      122              
Files Changed Coverage Δ
projects/components/src/table/table.component.ts 78.18% <100.00%> (+0.09%) :arrow_up:
projects/observability/src/public-api.ts 100.00% <100.00%> (ø)
...d/widgets/table/table-widget-renderer.component.ts 46.61% <100.00%> (+0.92%) :arrow_up:
...global-csv-download/global-csv-download.service.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   51m 57s :stopwatch: -23s 1 121 tests ±0  1 121 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 131 runs  ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit d445ce7d. ± Comparison against base commit 3d8488f8.

itssharmasandeep commented 1 year ago

What is the actual use case of this? Why can't we directly use FileDownloadService and why do we need registration?

palbizu commented 1 year ago

What is the actual use case of this? Why can't we directly use FileDownloadService and why do we need registration?

Provide a way to share multi-level data through different components, applying it for tables, dashboard and generic components

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   48m 3s :stopwatch: - 4m 17s 1 121 tests ±0  1 121 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 131 runs  ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 6bd701dd. ± Comparison against base commit 3d8488f8.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   45m 42s :stopwatch: - 6m 38s 1 121 tests ±0  1 121 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 131 runs  ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 1e97a345. ± Comparison against base commit 3d8488f8.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   48m 22s :stopwatch: - 3m 58s 1 121 tests ±0  1 121 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 131 runs  ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit a428b8c2. ± Comparison against base commit 3d8488f8.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   45m 26s :stopwatch: - 6m 54s 1 120 tests  - 1  1 120 :heavy_check_mark:  - 1  0 :zzz: ±0  0 :x: ±0  1 130 runs   - 1  1 130 :heavy_check_mark:  - 1  0 :zzz: ±0  0 :x: ±0 

Results for commit 6989b7ef. ± Comparison against base commit 3d8488f8.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   43m 27s :stopwatch: - 8m 59s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit fe5daab3. ± Comparison against base commit 31ad2bca.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   45m 56s :stopwatch: - 3m 0s 1 120 tests ±0  1 112 :heavy_check_mark:  - 8  0 :zzz: ±0  8 :x: +8  1 130 runs  ±0  1 121 :heavy_check_mark:  - 9  0 :zzz: ±0  9 :x: +9 

For more details on these failures, see this check.

Results for commit 0be92d0c. ± Comparison against base commit 04963bee.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   50m 2s :stopwatch: + 1m 6s 1 120 tests ±0  1 112 :heavy_check_mark:  - 8  0 :zzz: ±0  8 :x: +8  1 130 runs  ±0  1 121 :heavy_check_mark:  - 9  0 :zzz: ±0  9 :x: +9 

For more details on these failures, see this check.

Results for commit 71d58efe. ± Comparison against base commit 04963bee.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   49m 12s :stopwatch: +16s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 0f33ce69. ± Comparison against base commit 04963bee.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   44m 12s :stopwatch: - 4m 44s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 0f33ce69. ± Comparison against base commit 04963bee.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   49m 16s :stopwatch: +20s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit a507a72e. ± Comparison against base commit 04963bee.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   47m 13s :stopwatch: - 1m 43s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 81d1ad32. ± Comparison against base commit 04963bee.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     310 suites  +1   49m 29s :stopwatch: +33s 1 122 tests +2  1 122 :heavy_check_mark: +2  0 :zzz: ±0  0 :x: ±0  1 132 runs  +2  1 132 :heavy_check_mark: +2  0 :zzz: ±0  0 :x: ±0 

Results for commit 189f8347. ± Comparison against base commit 04963bee.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     310 suites  +1   52m 30s :stopwatch: + 7m 4s 1 122 tests +2  1 122 :heavy_check_mark: +2  0 :zzz: ±0  0 :x: ±0  1 132 runs  +2  1 132 :heavy_check_mark: +2  0 :zzz: ±0  0 :x: ±0 

Results for commit de81db93. ± Comparison against base commit eae893f7.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     310 suites  +1   49m 5s :stopwatch: + 1m 54s 1 123 tests +2  1 123 :heavy_check_mark: +2  0 :zzz: ±0  0 :x: ±0  1 133 runs  +2  1 133 :heavy_check_mark: +2  0 :zzz: ±0  0 :x: ±0 

Results for commit d804365e. ± Comparison against base commit f4ae9536.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     310 suites  +1   41m 27s :stopwatch: - 5m 44s 1 123 tests +2  1 123 :heavy_check_mark: +2  0 :zzz: ±0  0 :x: ±0  1 133 runs  +2  1 133 :heavy_check_mark: +2  0 :zzz: ±0  0 :x: ±0 

Results for commit 17f4dca7. ± Comparison against base commit f4ae9536.