hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix: issue with splitter expanding to height of content instead of cl… #2383

Closed jake-bassett closed 1 year ago

jake-bassett commented 1 year ago

…amping to desired dimensions

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2383 (49d8623) into main (779905f) will decrease coverage by 0.01%. Report is 1 commits behind head on main. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2383      +/-   ##
==========================================
- Coverage   82.74%   82.74%   -0.01%     
==========================================
  Files         918      918              
  Lines       20485    20493       +8     
  Branches     3230     3234       +4     
==========================================
+ Hits        16950    16956       +6     
- Misses       3406     3408       +2     
  Partials      129      129              
Files Changed Coverage Δ
...ects/components/src/splitter/splitter.component.ts 75.83% <66.66%> (-0.24%) :arrow_down:
...y/src/pages/explorer/explorer-dashboard-builder.ts 88.88% <80.00%> (-0.59%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   48m 9s :stopwatch: -13s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 49d86237. ± Comparison against base commit d77872d5.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   44m 31s :stopwatch: - 3m 51s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 5ac41978. ± Comparison against base commit d77872d5.