hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix: table component should emit column change when columns are updated #2399

Closed arjunlalb closed 1 year ago

arjunlalb commented 1 year ago

Description

Table component should emit the column list whenever its updated.

Testing

Manual testing done.

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #2399 (6cf723a) into main (ca2a8f9) will increase coverage by 30.30%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #2399       +/-   ##
===========================================
+ Coverage   52.62%   82.93%   +30.30%     
===========================================
  Files         920      920               
  Lines       20490    20493        +3     
  Branches     3223     3223               
===========================================
+ Hits        10783    16995     +6212     
+ Misses       9281     3376     -5905     
+ Partials      426      122      -304     
Files Changed Coverage Δ
projects/components/src/table/table.component.ts 78.08% <100.00%> (+24.28%) :arrow_up:

... and 300 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   45m 30s :stopwatch: + 5m 14s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit d55a5d70. ± Comparison against base commit 977f1c84.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   49m 47s :stopwatch: + 9m 31s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 24f26a39. ± Comparison against base commit 977f1c84.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   45m 5s :stopwatch: + 4m 49s 1 120 tests ±0  1 120 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 130 runs  ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit d3186245. ± Comparison against base commit 977f1c84.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files     309 suites   43m 4s :stopwatch: 1 121 tests 1 121 :heavy_check_mark: 0 :zzz: 0 :x: 1 131 runs  1 131 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 6cf723ab.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   46m 24s :stopwatch: -49s 1 121 tests +1  1 121 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0  1 131 runs  +1  1 131 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit 80619ef8. ± Comparison against base commit ca2a8f99.