Closed itssharmasandeep closed 1 year ago
Merging #2402 (0aa4990) into main (447363c) will decrease coverage by
38.59%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #2402 +/- ##
===========================================
- Coverage 82.99% 44.41% -38.59%
===========================================
Files 921 921
Lines 20566 20566
Branches 3245 3245
===========================================
- Hits 17069 9134 -7935
- Misses 3375 10904 +7529
- Partials 122 528 +406
Files | Coverage Ξ | |
---|---|---|
...y/entity-topology-graphql-query-handler.service.ts | 15.21% <0.00%> (-80.44%) |
:arrow_down: |
... and 324 files with indirect coverage changes
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
βββββββ4 filesβ Β±0βββββ310 suitesβ Β±0βββ48m 47s :stopwatch: + 7m 55s 1β124 tests Β±0ββ1β124 :heavy_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β 1β134 runsβ Β±0ββ1β134 :heavy_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β
Results for commit d5ce3300.βΒ± Comparison against base commit 46309efa.
βββββββ4 filesβ Β±0βββββ310 suitesβ Β±0βββ42m 57s :stopwatch: - 6m 29s 1β126 tests Β±0ββ1β126 :heavy_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β 1β136 runsβ Β±0ββ1β136 :heavy_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β
Results for commit 5b5f23b4.βΒ± Comparison against base commit df15d513.
βββββββ4 filesβ Β±0βββββ311 suitesβ Β±0βββ52m 12s :stopwatch: + 3m 5s 1β127 tests Β±0ββ1β127 :heavy_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β 1β137 runsβ Β±0ββ1β137 :heavy_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β
Results for commit 0aa4990d.βΒ± Comparison against base commit 447363cc.
βββββββ4 filesβ Β±0βββββ311 suitesβ Β±0βββ48m 26s :stopwatch: -41s 1β127 tests Β±0ββ1β127 :heavy_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β 1β137 runsβ Β±0ββ1β137 :heavy_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β
Results for commit 1f87f1c3.βΒ± Comparison against base commit 447363cc.
π΅βπ« ISSUE
Whenever we apply an edge filter for a particular entity, we need to omit the edges for all the other entities and only query for the particular entity edge. Once we do that and remove the filter, the query fired still doesn't contain the omitted edges and only contains the edge filter once, which leads to the wrong results
FIX π¨
This is happening because of the
id
field in the entities query. This field is used by Apollo to cache the query structure. Once we change this and use an aliasentityId
this starts working fine. We did a similar thing earlier for another issue with entities query. https://github.com/hypertrace/hypertrace-ui/pull/2334NOTE:
EntityTopologyGraphQlQueryHandlerService
has its own implementation ofentities
query