hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

feat: support for path while setting a cookie #2404

Open arjunlalb opened 1 year ago

arjunlalb commented 1 year ago

Description

Support for setting a path in the cookie.

Testing

Verified manually.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     310 suites  ±0   46m 13s :stopwatch: + 4m 24s 1 124 tests ±0  1 124 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 134 runs  ±0  1 134 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 67dda0c6. ± Comparison against base commit 1e8d426a.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2404 (07e4313) into main (1e8d426) will increase coverage by 0.00%. The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #2404   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files         921      921           
  Lines       20546    20547    +1     
  Branches     3239     3240    +1     
=======================================
+ Hits        17048    17049    +1     
  Misses       3376     3376           
  Partials      122      122           
Files Changed Coverage Δ
...on/src/utilities/browser/cookies/cookie.service.ts 50.00% <33.33%> (+2.17%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     310 suites  ±0   53m 43s :stopwatch: + 11m 54s 1 124 tests ±0  1 124 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 134 runs  ±0  1 134 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 07e43136. ± Comparison against base commit 1e8d426a.

aaron-steinfeld commented 1 year ago

Very curious on use case here