hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix: updates to table and table widget renderer #2411

Closed arjunlalb closed 1 year ago

arjunlalb commented 1 year ago

Currently the table does not emit via columnConfigsChange when the configs are updated. Also, the table column configs are internally modified with state information.

This PR does the following.

  1. Emit column list via columnConfigsChange
  2. Table Widget Renderer (TWR) should only write non state columns to preferences.
  3. On change, the table component should reinitialize columns on columnConfigs change only if non-state columns have changed.
codecov[bot] commented 1 year ago

Codecov Report

Merging #2411 (9ac27a0) into main (ad8832e) will decrease coverage by 25.80%. The diff coverage is 85.29%.

@@             Coverage Diff             @@
##             main    #2411       +/-   ##
===========================================
- Coverage   82.87%   57.07%   -25.80%     
===========================================
  Files         921      922        +1     
  Lines       20543    20564       +21     
  Branches     3239     3245        +6     
===========================================
- Hits        17024    11736     -5288     
- Misses       3394     8440     +5046     
- Partials      125      388      +263     
Files Changed Coverage Δ
projects/components/src/table/table.component.ts 54.10% <80.00%> (-21.88%) :arrow_down:
projects/components/src/public-api.ts 100.00% <100.00%> (ø)
...cts/components/src/table/util/table-column.util.ts 100.00% <100.00%> (ø)
...d/widgets/table/table-widget-renderer.component.ts 44.30% <100.00%> (+1.93%) :arrow_up:

... and 210 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files     310 suites   47m 51s :stopwatch: 1 123 tests 1 117 :heavy_check_mark: 0 :zzz: 6 :x: 1 133 runs  1 127 :heavy_check_mark: 0 :zzz: 6 :x:

For more details on these failures, see this check.

Results for commit 9ac27a0d.