hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix: add gql request name support #2419

Open itssharmasandeep opened 1 year ago

itssharmasandeep commented 1 year ago

⚠️ Issue

Currently, we fire a lot of queries of the same type, for example: we may fire up to 10 different entity queries for different use cases. Since we have a number of queries of the same type, debugging becomes difficult for the teams as they have to look for the schema to realize which query is failing and what is the use case.

πŸ’‘ Solution

Added an optional attribute name in the Graphql options which can be used to fire a names query depending upon the use case

Before

query {...}

After

query abcd {...}
codecov[bot] commented 1 year ago

Codecov Report

Merging #2419 (100d43c) into main (02e5209) will decrease coverage by 25.83%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #2419       +/-   ##
===========================================
- Coverage   82.83%   57.00%   -25.83%     
===========================================
  Files         921      921               
  Lines       20547    20549        +2     
  Branches     3241     3243        +2     
===========================================
- Hits        17020    11714     -5306     
- Misses       3402     8445     +5043     
- Partials      125      390      +265     
Files Changed Coverage Ξ”
projects/graphql-client/src/graphql-config.ts 100.00% <ΓΈ> (ΓΈ)
...ects/graphql-client/src/graphql-request.service.ts 10.44% <0.00%> (-83.50%) :arrow_down:

... and 211 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

βŸβ€„β€ˆβŸβ€„βŸβ€„4 files  Β±0β€‚β€ƒβŸβ€„β€ˆ310 suites  Β±0   49m 59s :stopwatch: + 6m 59s 1β€ˆ123 tests Β±0  1β€ˆ117 :heavy_check_mark:  -β€Š6  0 :zzz: Β±0  6 :x: +6  1β€ˆ133 runs  Β±0  1β€ˆ127 :heavy_check_mark:  -β€Š6  0 :zzz: Β±0  6 :x: +6 

For more details on these failures, see this check.

Results for commit 100d43cc. ± Comparison against base commit 02e52095.