hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix: refactoring legend element #2424

Closed palbizu closed 11 months ago

palbizu commented 1 year ago

Description

Legend's filter refactoring

Testing

Locally tested

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2424 (49c768a) into main (c781385) will decrease coverage by 0.07%. The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main    #2424      +/-   ##
==========================================
- Coverage   82.98%   82.92%   -0.07%     
==========================================
  Files         921      921              
  Lines       20558    20560       +2     
  Branches     3245     3246       +1     
==========================================
- Hits        17061    17049      -12     
- Misses       3375     3389      +14     
  Partials      122      122              
Files Changed Coverage Δ
...-button-wrapper/filter-button-wrapper.component.ts 50.00% <0.00%> (-50.00%) :arrow_down:
...rvability/src/shared/components/cartesian/chart.ts 100.00% <ø> (ø)
...hql/explore/explore-cartesian-data-source.model.ts 85.71% <0.00%> (+1.20%) :arrow_up:
...components/cartesian/d3/legend/cartesian-legend.ts 89.20% <75.00%> (-2.83%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     310 suites  ±0   48m 8s :stopwatch: + 2m 29s 1 126 tests ±0  1 126 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 136 runs  ±0  1 136 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 49c768a3. ± Comparison against base commit c7813854.