fix: disallow splitter overflow

hypertrace / hypertrace-ui

UI for Hypertrace

Other

25 stars 12 forks source link

fix: disallow splitter overflow #2430

Closed jake-bassett closed 1 year ago

jake-bassett commented 1 year ago

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2430 (6d1f6fa) into main (967e0b8) will decrease coverage by 30.23%. Report is 1 commits behind head on main. The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2430       +/-   ##
===========================================
- Coverage   82.98%   52.76%   -30.23%     
===========================================
  Files         921      921               
  Lines       20558    20558               
  Branches     3245     3245               
===========================================
- Hits        17061    10847     -6214     
- Misses       3375     9286     +5911     
- Partials      122      425      +303

see 300 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

      4 files   310 suites 46m 53s :stopwatch: 1 126 tests 1 126 :heavy_check_mark: 0 :zzz: 0 :x: 1 136 runs 1 136 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 6d1f6fa7.

github-actions[bot] commented 1 year ago

Unit Test Results

      4 files   310 suites 45m 26s :stopwatch: 1 126 tests 1 126 :heavy_check_mark: 0 :zzz: 0 :x: 1 136 runs 1 136 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 6778bc02.