fix: renaming variables in span details

hypertrace / hypertrace-ui

UI for Hypertrace

Other

25 stars 12 forks source link

fix: renaming variables in span details #2435

Closed palbizu closed 1 year ago

palbizu commented 1 year ago

Description

Fixing issue added in https://github.com/hypertrace/hypertrace-ui/pull/2414

Testing

Locally tested

Checklist:

[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

github-actions[bot] commented 1 year ago

Unit Test Results

      4 files ±0   311 suites ±0 54m 49s :stopwatch: + 4m 21s 1 127 tests ±0 1 127 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 1 137 runs ±0 1 137 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit f525fbd9. ± Comparison against base commit 8605c421.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2435 (f525fbd) into main (8605c42) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2435   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files         921      921           
  Lines       20566    20566           
  Branches     3245     3245           
=======================================
  Hits        17069    17069           
  Misses       3375     3375           
  Partials      122      122

Files	Coverage Δ
...call/headers/span-detail-call-headers.component.ts	`100.00% <100.00%> (ø)`
...an-detail/request/span-request-detail.component.ts	`100.00% <ø> (ø)`
...-detail/response/span-response-detail.component.ts	`100.00% <ø> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

      4 files ±0   311 suites ±0 47m 39s :stopwatch: - 2m 49s 1 127 tests ±0 1 127 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 1 137 runs ±0 1 137 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit f525fbd9. ± Comparison against base commit 8605c421.

github-actions[bot] commented 1 year ago

Unit Test Results

      4 files ±0   311 suites ±0 49m 7s :stopwatch: - 1m 21s 1 127 tests ±0 1 127 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 1 137 runs ±0 1 137 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit 447363cc. ± Comparison against base commit 8605c421.