hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

refactor: shared explorer url parsing logic #2441

Closed 23nobody closed 1 year ago

23nobody commented 1 year ago

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2441 (2178cc1) into main (737d327) will increase coverage by 0.02%. The diff coverage is 87.27%.

@@            Coverage Diff             @@
##             main    #2441      +/-   ##
==========================================
+ Coverage   83.02%   83.05%   +0.02%     
==========================================
  Files         918      919       +1     
  Lines       20450    20467      +17     
  Branches     3231     3233       +2     
==========================================
+ Hits        16979    16998      +19     
+ Misses       3351     3350       -1     
+ Partials      120      119       -1     
Files Coverage Δ
...ponents/src/filtering/filter/filter-url.service.ts 75.94% <100.00%> (ø)
...rvability/src/pages/explorer/explorer.component.ts 88.29% <100.00%> (+4.69%) :arrow_up:
projects/observability/src/public-api.ts 100.00% <100.00%> (ø)
.../src/pages/explorer/explorer-url-parser.service.ts 83.33% <83.33%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     311 suites  ±0   46m 43s :stopwatch: - 1m 26s 1 127 tests ±0  1 127 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 137 runs  ±0  1 137 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 20350cc4. ± Comparison against base commit 6c4c4f4e.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     311 suites  ±0   44m 40s :stopwatch: - 3m 29s 1 128 tests +1  1 128 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0  1 138 runs  +1  1 138 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit 11f98a3a. ± Comparison against base commit 6c4c4f4e.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     311 suites  ±0   47m 41s :stopwatch: -28s 1 128 tests +1  1 128 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0  1 138 runs  +1  1 138 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit 54b59e38. ± Comparison against base commit 6c4c4f4e.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     311 suites  ±0   47m 53s :stopwatch: -16s 1 128 tests +1  1 128 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0  1 138 runs  +1  1 138 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit 8cda689b. ± Comparison against base commit 6c4c4f4e.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     311 suites  ±0   47m 22s :stopwatch: + 1m 24s 1 128 tests ±0  1 128 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 138 runs  ±0  1 138 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 35cd3d62. ± Comparison against base commit 7cbf5266.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites   - 2   46m 8s :stopwatch: +10s 1 122 tests  - 6  1 122 :heavy_check_mark:  - 6  0 :zzz: ±0  0 :x: ±0  1 132 runs   - 6  1 132 :heavy_check_mark:  - 6  0 :zzz: ±0  0 :x: ±0 

Results for commit 0af0115b. ± Comparison against base commit 7cbf5266.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   51m 19s :stopwatch: + 6m 29s 1 122 tests ±0  1 122 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 132 runs  ±0  1 132 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 2178cc1a. ± Comparison against base commit 737d327d.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   47m 12s :stopwatch: + 2m 22s 1 122 tests ±0  1 122 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 132 runs  ±0  1 132 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 2178cc1a. ± Comparison against base commit 737d327d.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     309 suites  ±0   54m 0s :stopwatch: + 9m 10s 1 122 tests ±0  1 122 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 132 runs  ±0  1 132 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 6bba669d. ± Comparison against base commit 737d327d.