refactor: emitting on time range observable for refresh

hypertrace / hypertrace-ui

UI for Hypertrace

Other

25 stars 12 forks source link

refactor: emitting on time range observable for refresh #2457

Closed anandtiwary closed 11 months ago

anandtiwary commented 11 months ago

Description

Please include a summary of the change, motivation and context. refactor: emitting on time range observable for refresh

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

codecov[bot] commented 11 months ago

Codecov Report

Merging #2457 (89ba883) into main (0a7e4b1) will increase coverage by 9.63%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2457      +/-   ##
==========================================
+ Coverage   70.16%   79.79%   +9.63%     
==========================================
  Files         918      918              
  Lines       20447    20449       +2     
  Branches     3231     3231              
==========================================
+ Hits        14347    16318    +1971     
+ Misses       5870     3994    -1876     
+ Partials      230      137      -93

Files	Coverage Δ
projects/common/src/time/time-range.service.ts	`90.41% <100.00%> (+18.57%)`	:arrow_up:

... and 203 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 11 months ago

Unit Test Results

      4 files   309 suites 45m 51s :stopwatch: 1 122 tests 1 122 :heavy_check_mark: 0 :zzz: 0 :x: 1 132 runs 1 132 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit bd45f28e.

github-actions[bot] commented 11 months ago

Unit Test Results

      4 files   309 suites 45m 39s :stopwatch: 1 122 tests 1 122 :heavy_check_mark: 0 :zzz: 0 :x: 1 132 runs 1 132 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 89ba8835.

github-actions[bot] commented 11 months ago

Unit Test Results

      4 files   309 suites 45m 37s :stopwatch: 1 122 tests 1 122 :heavy_check_mark: 0 :zzz: 0 :x: 1 132 runs 1 132 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit cd39d374.