hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

feat: improvements to table csv download logic #2473

Closed arjunlalb closed 1 year ago

arjunlalb commented 1 year ago

Description

Improvements to table CSV download flow.

  1. Add optional input to table for CSV download configs.
  2. Use limit from the above for download data query. If limit is unavailable, default to 1000.
  3. Use the filename from config. If unavailable, use fallback logic using table ID.
  4. For column keys, preference order is column title -> column name -> column id
  5. Update timestamp csv generator.
codecov[bot] commented 1 year ago

Codecov Report

Merging #2473 (4b44991) into main (101357c) will decrease coverage by 26.37%. The diff coverage is 72.72%.

@@             Coverage Diff             @@
##             main    #2473       +/-   ##
===========================================
- Coverage   83.07%   56.71%   -26.37%     
===========================================
  Files         924      924               
  Lines       20592    20596        +4     
  Branches     3252     3255        +3     
===========================================
- Hits        17107    11680     -5427     
- Misses       3366     8527     +5161     
- Partials      119      389      +270     
Files Coverage Δ
...src/download-file/service/file-download.service.ts 90.00% <ø> (ø)
...v-generators/table-cell-timestamp-csv-generator.ts 100.00% <100.00%> (ø)
...mponents/src/table/table-csv-downloader.service.ts 89.47% <100.00%> (+0.28%) :arrow_up:
projects/components/src/table/table.service.ts 96.00% <100.00%> (ø)
projects/components/src/table/table.component.ts 53.34% <0.00%> (-26.87%) :arrow_down:

... and 214 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     314 suites   - 1   48m 35s :stopwatch: - 3m 33s 1 128 tests  - 2  1 128 :heavy_check_mark:  - 2  0 :zzz: ±0  0 :x: ±0  1 138 runs   - 2  1 138 :heavy_check_mark:  - 2  0 :zzz: ±0  0 :x: ±0 

Results for commit 2607e216. ± Comparison against base commit 101357cb.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     314 suites   - 1   49m 5s :stopwatch: - 3m 3s 1 128 tests  - 2  1 128 :heavy_check_mark:  - 2  0 :zzz: ±0  0 :x: ±0  1 138 runs   - 2  1 138 :heavy_check_mark:  - 2  0 :zzz: ±0  0 :x: ±0 

Results for commit 1991d53f. ± Comparison against base commit 101357cb.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     315 suites  ±0   50m 35s :stopwatch: - 1m 33s 1 130 tests ±0  1 129 :heavy_check_mark:  - 1  0 :zzz: ±0  1 :x: +1  1 140 runs  ±0  1 139 :heavy_check_mark:  - 1  0 :zzz: ±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit 1a7d86f6. ± Comparison against base commit 101357cb.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     315 suites  ±0   50m 42s :stopwatch: - 1m 26s 1 130 tests ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 140 runs  ±0  1 140 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 4b449915. ± Comparison against base commit 101357cb.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     315 suites  ±0   50m 12s :stopwatch: - 1m 56s 1 130 tests ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 140 runs  ±0  1 140 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 4b449915. ± Comparison against base commit 101357cb.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     315 suites  ±0   48m 48s :stopwatch: - 3m 20s 1 130 tests ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 140 runs  ±0  1 140 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 4b449915. ± Comparison against base commit 101357cb.

github-actions[bot] commented 1 year ago

Unit Test Results

       4 files  ±0     315 suites  ±0   50m 8s :stopwatch: - 2m 0s 1 130 tests ±0  1 130 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 140 runs  ±0  1 140 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 54359c1a. ± Comparison against base commit 101357cb.