hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix: use keys from across all rows to construct csv object #2478

Closed arjunlalb closed 11 months ago

arjunlalb commented 11 months ago

Description

CSV download logic should look at all keys across the row list, not just first row.

codecov[bot] commented 11 months ago

Codecov Report

Merging #2478 (7e397df) into main (dd44c68) will decrease coverage by 30.29%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #2478       +/-   ##
===========================================
- Coverage   83.05%   52.77%   -30.29%     
===========================================
  Files         925      925               
  Lines       20612    20610        -2     
  Branches     3256     3254        -2     
===========================================
- Hits        17120    10876     -6244     
- Misses       3373     9319     +5946     
- Partials      119      415      +296     
Files Coverage Δ
...src/download-file/service/file-download.service.ts 91.66% <100.00%> (+1.66%) :arrow_up:

... and 299 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files  ±0     316 suites  ±0   47m 1s :stopwatch: - 4m 2s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 7210596f. ± Comparison against base commit c7064f60.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files  ±0     316 suites  ±0   49m 31s :stopwatch: - 1m 32s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cc76e34b. ± Comparison against base commit c7064f60.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files  ±0     316 suites  ±0   52m 35s :stopwatch: + 1m 32s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 246cbd40. ± Comparison against base commit c7064f60.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files  ±0     316 suites  ±0   49m 1s :stopwatch: - 2m 2s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 1a62ad49. ± Comparison against base commit c7064f60.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files  ±0     316 suites  ±0   50m 59s :stopwatch: -4s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 6b4d3d18. ± Comparison against base commit c7064f60.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files     316 suites   47m 43s :stopwatch: 1 131 tests 1 131 :heavy_check_mark: 0 :zzz: 0 :x: 1 141 runs  1 141 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 7e397df6.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files     316 suites   47m 6s :stopwatch: 1 131 tests 1 131 :heavy_check_mark: 0 :zzz: 0 :x: 1 141 runs  1 141 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 3170394a.