hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

feat(file-upload): show info toast when diff file type is uploaded #2484

Closed adisreyaj closed 11 months ago

adisreyaj commented 11 months ago

File type validation in the browser is not reliable. So instead of stopping the flow, we show an Info toast and let the user proceed.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files     316 suites   49m 24s :stopwatch: 1 131 tests 1 130 :heavy_check_mark: 0 :zzz: 1 :x: 1 141 runs  1 140 :heavy_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit 280a82bb.

codecov[bot] commented 11 months ago

Codecov Report

Merging #2484 (51eca76) into main (92ce31a) will not change coverage. Report is 1 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head 51eca76 differs from pull request most recent head 1ec1bfa. Consider uploading reports for the commit 1ec1bfa to get more accurate results

@@           Coverage Diff           @@
##             main    #2484   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files         925      925           
  Lines       20610    20610           
  Branches     3254     3254           
=======================================
  Hits        17119    17119           
  Misses       3372     3372           
  Partials      119      119           
Files Coverage Δ
...omponents/src/file-upload/file-upload.component.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files     316 suites   48m 57s :stopwatch: 1 131 tests 1 131 :heavy_check_mark: 0 :zzz: 0 :x: 1 141 runs  1 141 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 51eca762.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files     316 suites   53m 27s :stopwatch: 1 131 tests 1 131 :heavy_check_mark: 0 :zzz: 0 :x: 1 141 runs  1 141 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 51eca762.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files  ±0     316 suites  ±0   53m 49s :stopwatch: +36s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 1ec1bfa5. ± Comparison against base commit f009f43e.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files  ±0     316 suites  ±0   45m 49s :stopwatch: - 7m 24s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit f27ba76a. ± Comparison against base commit f009f43e.