hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

feat: Removing Filters from span details in waterfall widget #2502

Closed palbizu closed 10 months ago

palbizu commented 11 months ago

Description

Setting variable to remove filters from Span Details in multiple components (specifically Waterfall Widget) and fixing filter's styles.

Testing

Locally tested

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

github-actions[bot] commented 11 months ago

Unit Test Results

       4 files     316 suites   45m 10s :stopwatch: 1 131 tests 1 131 :heavy_check_mark: 0 :zzz: 0 :x: 1 141 runs  1 141 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit df90e5a9.

anandtiwary commented 11 months ago

As discussed, please share a screenshot with these filter icons always visible. Let's share it with Sudeep and see if he likes it.

codecov[bot] commented 10 months ago

Codecov Report

Merging #2502 (be2066f) into main (418e1ef) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2502      +/-   ##
==========================================
- Coverage   83.04%   83.04%   -0.01%     
==========================================
  Files         925      925              
  Lines       20616    20620       +4     
  Branches     3257     3257              
==========================================
+ Hits        17120    17123       +3     
- Misses       3376     3377       +1     
  Partials      120      120              
Files Coverage Δ
...call/headers/span-detail-call-headers.component.ts 84.61% <100.00%> (-3.39%) :arrow_down:
...an-detail/request/span-request-detail.component.ts 100.00% <ø> (ø)
...-detail/response/span-response-detail.component.ts 100.00% <ø> (ø)
...ed/components/span-detail/span-detail.component.ts 90.38% <100.00%> (+0.18%) :arrow_up:
...nts/span-detail/tags/span-tags-detail.component.ts 84.00% <100.00%> (+0.66%) :arrow_up:
...s/waterfall/waterfall-widget-renderer.component.ts 53.84% <ø> (ø)
...hboard/widgets/waterfall/waterfall-widget.model.ts 66.66% <100.00%> (+4.16%) :arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

github-actions[bot] commented 10 months ago

Unit Test Results

       4 files     316 suites   36m 9s :stopwatch: 1 131 tests 1 131 :heavy_check_mark: 0 :zzz: 0 :x: 1 141 runs  1 141 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit df90e5a9.

github-actions[bot] commented 10 months ago

Unit Test Results

       4 files  ±0     316 suites  ±0   38m 57s :stopwatch: - 11m 51s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit be2066f7. ± Comparison against base commit 418e1ef2.

github-actions[bot] commented 10 months ago

Unit Test Results

       4 files  ±0     316 suites  ±0   47m 48s :stopwatch: - 3m 0s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 1dc53b9d. ± Comparison against base commit 418e1ef2.