hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

Fix: Paginator positioning and alignment for full page tables isn't correct #2517

Open aneeshsharma opened 1 year ago

aneeshsharma commented 1 year ago

Description

Pagination element for full page tables was positioned as fixed. Which meant if the width was set to 100%, it will take the width of the viewport and not the width of the parent table.

This leads to the positioning of the element being incorrect as well as alignment being off.

Solution is to make the pagination element position: sticky, that way width: 100% takes the width of the parent table and not the viewport.

This does mean that full page tables and embedded tables are now not different in terms of pagination.

Testing

I tested a few configurations of tables manually, as well as ran unit tests to make sure nothing is breaking with the change.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a3e3e12) 82.99% compared to head (ca34238) 82.99%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2517 +/- ## ======================================= Coverage 82.99% 82.99% ======================================= Files 925 925 Lines 20636 20636 Branches 3260 3260 ======================================= Hits 17127 17127 Misses 3389 3389 Partials 120 120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 year ago

Test Results

       4 files     316 suites   31m 30s :stopwatch: 1 131 tests 1 131 :heavy_check_mark: 0 :zzz: 0 :x: 1 141 runs  1 141 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit ca342383.

:recycle: This comment has been updated with latest results.