Open aneeshsharma opened 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a3e3e12
) 82.99% compared to head (ca34238
) 82.99%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
4 files 316 suites 31m 30s :stopwatch: 1 131 tests 1 131 :heavy_check_mark: 0 :zzz: 0 :x: 1 141 runs 1 141 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit ca342383.
:recycle: This comment has been updated with latest results.
Description
Pagination element for full page tables was positioned as
fixed
. Which meant if thewidth
was set to100%
, it will take the width of the viewport and not the width of the parent table.This leads to the positioning of the element being incorrect as well as alignment being off.
Solution is to make the pagination element
position: sticky
, that waywidth: 100%
takes the width of the parent table and not the viewport.This does mean that full page tables and embedded tables are now not different in terms of pagination.
Testing
I tested a few configurations of tables manually, as well as ran unit tests to make sure nothing is breaking with the change.