Updating colors in chart

palbizu commented 10 months ago

Description

Pending:

Issue with colors and multiple metrics (colors repeated)
Issue with legends name (they should need to be taken from the legends name and not from data as in this case)
Issue with color in the tooltip (color not assigned)

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

github-actions[bot] commented 10 months ago

Test Results

      4 files   316 suites 42m 40s :stopwatch: 1 131 tests 1 129 :heavy_check_mark: 0 :zzz: 2 :x: 1 141 runs 1 139 :heavy_check_mark: 0 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit e0e0b0ca.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a3e3e12) 82.99% compared to head (e0e0b0c) 69.29%.

Files	Patch %	Lines
...hql/explore/explore-cartesian-data-source.model.ts	0.00%	8 Missing :warning:
...y/src/pages/explorer/explorer-dashboard-builder.ts	0.00%	1 Missing :warning:
...components/cartesian/d3/legend/cartesian-legend.ts	95.23%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2518 +/- ## =========================================== - Coverage 82.99% 69.29% -13.70% =========================================== Files 925 925 Lines 20636 20648 +12 Branches 3260 3269 +9 =========================================== - Hits 17127 14309 -2818 - Misses 3389 6089 +2700 - Partials 120 250 +130 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

palbizu commented 9 months ago

Already implemented by Anand

hypertrace / hypertrace-ui