hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix: table should not cache if filter or sort changes #2521

Closed aaron-steinfeld closed 1 year ago

aaron-steinfeld commented 1 year ago

Description

Caching on table was preventing requests from firing when the request changed

codecov[bot] commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (badfc16) 82.99% compared to head (a3fb33c) 83.01%.

Files Patch % Lines
...components/src/table/data/table-cdk-data-source.ts 42.85% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2521 +/- ## ========================================== + Coverage 82.99% 83.01% +0.01% ========================================== Files 925 925 Lines 20639 20636 -3 Branches 3260 3257 -3 ========================================== Hits 17130 17130 + Misses 3389 3386 -3 Partials 120 120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 year ago

Test Results

       4 files  ±0     316 suites  ±0   31m 39s :stopwatch: - 4m 11s 1 131 tests ±0  1 131 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 141 runs  ±0  1 141 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit a3fb33ce. ± Comparison against base commit badfc164.