hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

Fix: Separate collapsable and search history behaviour #2523

Closed aneeshsharma closed 10 months ago

aneeshsharma commented 10 months ago

Description

The collapsable behaviour of the search box was tied to whether search history was enabled or not.

Now added a separate input collapsable which can be set to true to make the search box collapsable and vice versa.

Search history is now independent of this.

github-actions[bot] commented 10 months ago

Test Results

       4 files  ±0     316 suites  ±0   31m 56s :stopwatch: +37s 1 135 tests +4  1 135 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0  1 145 runs  +4  1 145 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0 

Results for commit 0c05ea5f. ± Comparison against base commit fd5f5e32.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2c8a171) 83.01% compared to head (0c05ea5) 83.01%.

:exclamation: Current head 0c05ea5 differs from pull request most recent head 31594cb. Consider uploading reports for the commit 31594cb to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2523 +/- ## ======================================= Coverage 83.01% 83.01% ======================================= Files 925 925 Lines 20636 20637 +1 Branches 3257 3257 ======================================= + Hits 17130 17131 +1 Misses 3386 3386 Partials 120 120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.