search

hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix: add delete support in preferences service #2537

Closed arjunlalb closed 10 months ago

arjunlalb commented 10 months ago

Description

Support for deleting a preference key.

github-actions[bot] commented 10 months ago

Test Results

       4 files  ±0     316 suites  ±0   31m 13s :stopwatch: - 1m 10s 1 135 tests ±0  1 135 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 145 runs  ±0  1 145 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 2057ddbb. ± Comparison against base commit cf25fef7.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cf25fef) 83.00% compared to head (2057ddb) 82.99%.

:exclamation: Current head 2057ddb differs from pull request most recent head 63a6ea4. Consider uploading reports for the commit 63a6ea4 to get more accurate results

Files Patch % Lines
...ojects/common/src/preference/preference.service.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2537 +/- ## ========================================== - Coverage 83.00% 82.99% -0.01% ========================================== Files 925 925 Lines 20626 20628 +2 Branches 3252 3253 +1 ========================================== Hits 17120 17120 - Misses 3386 3388 +2 Partials 120 120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.