hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

Fix traces table replacing last #2539

Closed rahul-p-rajesh closed 10 months ago

rahul-p-rajesh commented 10 months ago

Description

Replaced "Last" in the paginator with the totalCount.

  1. on first page image
  2. on any other last page image

Checklist:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (98a2cd3) 82.20% compared to head (8ee4ae6) 82.20%.

:exclamation: Current head 8ee4ae6 differs from pull request most recent head 1fb1f55. Consider uploading reports for the commit 1fb1f55 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2539 +/- ## ======================================= Coverage 82.20% 82.20% ======================================= Files 927 927 Lines 20865 20854 -11 Branches 3312 3307 -5 ======================================= - Hits 17152 17143 -9 + Misses 3576 3574 -2 Partials 137 137 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

Test Results

       4 files  ±0     316 suites  ±0   31m 48s :stopwatch: +5s 1 135 tests ±0  1 135 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 145 runs  ±0  1 145 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 8ee4ae6f. ± Comparison against base commit d3ddf2a5.

:recycle: This comment has been updated with latest results.