hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

refactor: more flexibility with explorer #2548

Closed anandtiwary closed 10 months ago

anandtiwary commented 10 months ago

Description

Please include a summary of the change, motivation and context.

Screenshot 2023-12-06 at 3 10 11 PM Screenshot 2023-12-06 at 3 10 02 PM Screenshot 2023-12-04 at 10 32 00 PM Screenshot 2023-12-04 at 10 45 30 PM Screenshot 2023-12-04 at 10 45 40 PM

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (d36fcbb) 82.20% compared to head (997fc43) 81.93%.

Files Patch % Lines
...components/cartesian/d3/legend/cartesian-legend.ts 54.71% 23 Missing and 1 partial :warning:
.../components/cartesian/cartesian-chart.component.ts 18.18% 8 Missing and 1 partial :warning:
...d/components/cartesian/d3/chart/cartesian-chart.ts 0.00% 1 Missing :warning:
...c/shared/components/donut/donut-builder.service.ts 0.00% 1 Missing :warning:
...nents/radar/tooltip/radar-chart-tooltip.service.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2548 +/- ## ========================================== - Coverage 82.20% 81.93% -0.28% ========================================== Files 927 928 +1 Lines 20872 20901 +29 Branches 3313 3321 +8 ========================================== - Hits 17158 17125 -33 - Misses 3577 3638 +61 - Partials 137 138 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

Test Results

       4 files  ±0     316 suites  ±0   31m 59s :stopwatch: +19s 1 135 tests ±0  1 135 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 145 runs  ±0  1 145 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 997fc434. ± Comparison against base commit d36fcbb0.

:recycle: This comment has been updated with latest results.