hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

feat: metric aggregation type type guard #2574

Closed jake-bassett closed 9 months ago

jake-bassett commented 9 months ago

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

github-actions[bot] commented 9 months ago

Test Results

       4 files     316 suites   31m 31s :stopwatch: 1 135 tests 1 135 :heavy_check_mark: 0 :zzz: 0 :x: 1 145 runs  1 145 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit a345d628.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (360d03c) 81.93% compared to head (a345d62) 81.86%.

Files Patch % Lines
...shared/graphql/model/metrics/metric-aggregation.ts 26.08% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2574 +/- ## ========================================== - Coverage 81.93% 81.86% -0.07% ========================================== Files 928 928 Lines 20906 20924 +18 Branches 3323 3338 +15 ========================================== + Hits 17129 17130 +1 - Misses 3639 3656 +17 Partials 138 138 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.