search

hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix(time-duration): getMostSignificantUnitOnlyWithoutApprox created to avoid approx #2586

Closed rahul-p-rajesh closed 9 months ago

rahul-p-rajesh commented 9 months ago

Description

Currently getMostSignificantUnitOnly in time-duration updates the time value to an approximate value for e.g on providing 44hr it approximate to 1day

github-actions[bot] commented 9 months ago

Test Results

       4 files  ±0     316 suites  ±0   32m 32s :stopwatch: -1s 1 136 tests ±0  1 136 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 146 runs  ±0  1 146 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit ffd255da. ± Comparison against base commit 389047b0.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (389047b) 81.69% compared to head (ffd255d) 71.58%.

Files Patch % Lines
projects/common/src/time/time-duration.ts 0.00% 13 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2586 +/- ## =========================================== - Coverage 81.69% 71.58% -10.12% =========================================== Files 928 928 Lines 20790 20804 +14 Branches 3136 3141 +5 =========================================== - Hits 16984 14892 -2092 - Misses 3665 5659 +1994 - Partials 141 253 +112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.