hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

feat: add input option to select component to emit on select input ch… #2602

Closed jake-bassett closed 9 months ago

jake-bassett commented 9 months ago

…ange

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7080b66) 81.71% compared to head (8cda34d) 81.70%.

Files Patch % Lines
projects/components/src/select/select.component.ts 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2602 +/- ## ========================================== - Coverage 81.71% 81.70% -0.01% ========================================== Files 928 928 Lines 20794 20797 +3 Branches 3137 3138 +1 ========================================== + Hits 16991 16993 +2 - Misses 3662 3663 +1 Partials 141 141 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 9 months ago

Test Results

    4 files  ±0    316 suites  ±0   32m 24s :stopwatch: -29s 1 136 tests ±0  1 136 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 146 runs  ±0  1 146 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 8cda34d9. ± Comparison against base commit 7080b661.