hypertrace / hypertrace-ui

UI for Hypertrace
Other
25 stars 12 forks source link

fix: add `clickOnRowToSelect` option to table #2604

Open arjunlalb opened 10 months ago

arjunlalb commented 10 months ago

Description

With various usecases of table, it is not always required to select a row when its clicked on. There are usecases that just needs some action to be done on a row click instead of toggling its selection status.

To enable this, this PR introduces a boolean control in the table component.

Testing

Tested manually.

Checklist:

github-actions[bot] commented 10 months ago

Test Results

    4 files  ±0    317 suites  ±0   32m 47s :stopwatch: +15s 1 143 tests ±0  1 143 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 153 runs  ±0  1 153 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 9b591cec. ± Comparison against base commit cf7c36a3.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d9db405) 81.74% compared to head (9b591ce) 81.74%. Report is 1 commits behind head on main.

Files Patch % Lines
projects/components/src/table/table.component.ts 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2604 +/- ## ======================================= Coverage 81.74% 81.74% ======================================= Files 929 929 Lines 20845 20856 +11 Branches 3145 3153 +8 ======================================= + Hits 17039 17049 +10 Misses 3665 3665 - Partials 141 142 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.