replace jaeger.servicename with servicename

hypertrace / span-normalizer

A streaming job that converts the incoming spans into Hypertrace's raw span format

Apache License 2.0

0 stars 2 forks source link

replace jaeger.servicename with servicename #19

Closed dnielsen closed 3 years ago

dnielsen commented 4 years ago

Even jaeger would not qualify servicename as jaeger.servicename. So it is more sensible for HT to rename it to serviceName as idiomatically used in the rest of HT.

dnielsen commented 4 years ago

@buchi-busireddy 👍 for a non-breaking way

kotharironak commented 4 years ago

@anujgoyal1 This change will affect the simulator too. I think we have one option for this.

kotharironak commented 3 years ago

closing this now as it will be taken care of as part of - https://github.com/hypertrace/hypertrace/issues/44