search

hypertrace / span-normalizer

A streaming job that converts the incoming spans into Hypertrace's raw span format
Apache License 2.0
0 stars 2 forks source link

adds supports for pre-creation of topics #22

Closed kotharironak closed 3 years ago

kotharironak commented 4 years ago

See more details on - https://github.com/hypertrace/kafka-streams-framework/issues/5 And framework PR - https://github.com/hypertrace/kafka-streams-framework/pull/6

codefromthecrypt commented 4 years ago

one consideration is that this will eventually move to the macrorepo hypertrace-ingester, who should also house our test image for kafka-zookeeper. If the precreation is only for quick start, it could be handled as a layer in that image, particularly when they are in the same repo it won't be hard to track.

kotharironak commented 4 years ago

Merged these changes as part of the PR - https://github.com/hypertrace/span-normalizer/pull/18

kotharironak commented 4 years ago

@adriancole Yes, right if we are going to keep this pre-creation only for quick-start. But, I was thinking of exploring the option of removal of helm pre-install hook for this. If that's not the case, we can optimize this further as suggested.

kotharironak commented 4 years ago

closing this PR.

kotharironak commented 3 years ago

closing this as no longer required