search

hypertrace / span-normalizer

A streaming job that converts the incoming spans into Hypertrace's raw span format
Apache License 2.0
0 stars 2 forks source link

Add RpcFieldsGenerator for parsing rpc.* tags #28

Closed mohit-a21 closed 4 years ago

mohit-a21 commented 4 years ago

rpc. tags have been defined for Otel. Added Protocol generator for such tags. The custom rpc. tags defined gets translated to relevant rpc protocol such as grpc, java_rmi, etc. Since we support grpc only, for now, added support for translating of tags to grpc event field

Dependent on https://github.com/hypertrace/data-model/pull/9

codecov[bot] commented 4 years ago

Codecov Report

Merging #28 into main will increase coverage by 1.99%. The diff coverage is 91.20%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #28      +/-   ##
============================================
+ Coverage     81.66%   83.65%   +1.99%     
- Complexity      202      241      +39     
============================================
  Files            15       16       +1     
  Lines           709      826     +117     
  Branches         45       55      +10     
============================================
+ Hits            579      691     +112     
- Misses           98       99       +1     
- Partials         32       36       +4
Flag Coverage Δ Complexity Δ
#unit 83.65% <91.20%> (+1.99%) 241.00 <38.00> (+39.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../normalizer/constants/SpanNormalizerConstants.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...pannormalizer/fieldgenerators/FieldsGenerator.java 77.50% <83.33%> (+3.21%) 11.00 <1.00> (+2.00)
...normalizer/fieldgenerators/RpcFieldsGenerator.java 90.19% <90.19%> (ø) 19.00 <19.00> (?)
...ormalizer/fieldgenerators/GrpcFieldsGenerator.java 97.23% <92.64%> (-0.27%) 51.00 <18.00> (+17.00) :arrow_down:
...ormalizer/fieldgenerators/HttpFieldsGenerator.java 96.07% <0.00%> (+0.71%) 94.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea1aa32...4086cb5. Read the comment docs.