hypertrace / span-normalizer

A streaming job that converts the incoming spans into Hypertrace's raw span format
Apache License 2.0
0 stars 2 forks source link

Add prometheus jmx exporter for exporting kafka-streams metrics #30

Closed ravisingal closed 4 years ago

ravisingal commented 4 years ago

Added a sidecar container for exposing kafka-streams metrics to prometheus to scrape.

Prometheus now has to scrape two endpoints - admin port and prometheus jmx exporter port. one of them will be configured through pod annotations and second will be configured using service annotations. hence, a new service is also added to the helm chart.

codecov[bot] commented 4 years ago

Codecov Report

Merging #30 into main will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #30   +/-   ##
=========================================
  Coverage     83.69%   83.69%           
  Complexity      242      242           
=========================================
  Files            16       16           
  Lines           828      828           
  Branches         55       55           
=========================================
  Hits            693      693           
  Misses           99       99           
  Partials         36       36           
Flag Coverage Δ Complexity Δ
#unit 83.69% <ø> (ø) 242.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 769f31e...92e7253. Read the comment docs.