Closed tyn1998 closed 1 year ago
Hi @lhbvvvvv, the refactor of DeveloperActORTrend
should be similar with the one of RepoActORTrend
which is already done in #548. So I think you could have a try on this subtask :)
I would like to have a try. 😸
@wxharry Sure! You could try one or some of:
and I'm workding on xxxDetailxxx features. Met trouble last night, harder than I thought.
@wxharry Sure! You could try one or some of:
Then I will take the perceptorLayout and PerceptorTab for now.
and I'm workding on xxxDetailxxx features. Met trouble last night, harder than I thought.
Good luck on that one.
I recommend using Network Throttling
tool of Chrome DevTools to have the refactored features fully tested before submitting a PR:
Because in this way those bugs related to timings can be exposed.
Hi @lhbvvvvv, the refactor of
DeveloperActORTrend
should be similar with the one ofRepoActORTrend
which is already done in #548. So I think you could have a try on this subtask :)
I am very willing to try this subtask.
@wxharry @lhbvvvvv
Hi guys, I changed the branch name v2.0.0
to v1.9.0
in this repo just now. If you didn't start the tasks at all, you may follow these steps to kick off:
git fetch upstream v1.9.0
or git fetch upstream
for all branches and tags if you don't mindgit checkout -b <your_branch_name> upstream/v1.9.0
, now you have a working branchIf you have already started(i.e. you already have a branch which is checked out from upstream/v2.0.0), I think there is nothing special to do.
Well, there is a chance that you may have checked out a local v2.0.0 whose remote is upstream/v2.0.0, just like you have a local master whose remote is origin/master. I think you don't need a local v2.0.0 at all, just start your work by checking out a branch from the upstream/v2.0.0 and don't forget to fetch the upstream from time to time.
I hope the steps described are right.
Any plan about refactoring the rest of the features? @tyn1998
I'm gonna refactor RepoDetailIssue
, RepoDetailPR
, and RepoHeaderLabels
.
Would you like to try ProjectNetwork
? @wxharry
and, hello @lhbvvvvv, could you refactor DeveloperNetwork
?
I'm gonna refactor
RepoDetailIssue
,RepoDetailPR
, andRepoHeaderLabels
.Would you like to try
ProjectNetwork
? @wxharryand, hello @lhbvvvvv, could you refactor
DeveloperNetwork
?
Ok, I can try to do it.
Hi @wxharry, we have to abandon the use of fluentUI since its stylesheet is computed by JS which causes errors if we set "run_at": "document_start"
.
So further research is required and I will refactor the ProjectNetwork.
Just pushed a commit to v1.9.0 where I cherry-picked some commits from the latest master and also manually copy some code from master (cannot simply cherry-pick from a renamed file), however, all OSS-GPT related commits were untouched.
Next, I will refactor ProjectNetwork, DeveloperNetwork and OSS-GPT one by one.
This is a huge project and it's done!
Thank you @wxharry @lhbvvvvv
Description
In #548, we worked out a new feature loading mechanism and had
RepoActORTrend
refactored torepo-activity-openrank-trends
by this new mechanism.There are other existing features waiting to be refactored in that way and they are:
Each should be resolved by a PR targeted to the branch ~
v2.0.0
~v1.9.0
. This issue is opened for tracking the progress of refactoring and should be finally closed manually rather automatically by PR keywords.