hypertrons / hypertrons-crx

A browser extension for insights into GitHub projects and developers.
https://crx.hypertrons.io
Apache License 2.0
330 stars 91 forks source link

feat: media player controllers for contributor activity racing bar #744

Closed tyn1998 closed 9 months ago

tyn1998 commented 9 months ago

Brief Information

This pull request is in the type of (more info about types):

Related issues (all available keywords):

Details

In this PR I added media player controllers for the Racing Bar. I could say now the Racing Bar is the most complex feature in Hypercrx 😆 .

Video:

https://github.com/hypertrons/hypertrons-crx/assets/32434520/ec76ed01-11fc-4967-a124-5f2018328494

In light theme:

image

In dark theme:

image

Checklist

Others

tyn1998 commented 9 months ago

May I request for your reviews? @lhbvvvvv @wxharry

@zhaosj975 @Tenth-crew @wangyantong2000 Guys need you doing some tests, again ✌️

@andyhuang18 @wj23027 You two might benifit from this PR and gain knowledges for your OSPP projects :)

wxharry commented 9 months ago

Markdown file formats are changed in this pr, did you run prettier for all files including the markdowns? @tyn1998

wxharry commented 9 months ago

It still takes time to go to the latest bar chart when playing, espcially for large repo like vscode. Can we have a button to jump to the latest chart better support this issue?

tyn1998 commented 9 months ago

Markdown file formats are changed in this pr, did you run prettier for all files including the markdowns? @tyn1998

I checkedout this branch from https://github.com/hypertrons/hypertrons-crx/pull/744. In that PR markdown files are changed unintentionally by @lhbvvvvv but it's ok to keep those changes.

It still takes time to go to the latest bar chart when playing, espcially for large repo like vscode. Can we have a button to jump to the latest chart better support this issue?

When the racing bar is first rendered, it shows the latest data. The next button also support long press to go to the latest month. You may have a try :D

Tenth-crew commented 9 months ago

After clicking Pause, the animation will stop after a delay rather than immediately

https://github.com/hypertrons/hypertrons-crx/assets/68376741/c6371e11-ce1a-4868-a5fd-c9d3027013bc

wangyantong2000 commented 9 months ago

https://github.com/hypertrons/hypertrons-crx/assets/135088663/8e4373b4-74ad-46a3-890f-61445a7356cf

tyn1998 commented 9 months ago

@Tenth-crew @wangyantong2000 Thank you for testing!

After clicking Pause, the animation will stop after a delay rather than immediately

This is expected, since the running racing bar is not actually a video :)

HalloMelon commented 9 months ago

it is nicer~

https://github.com/hypertrons/hypertrons-crx/assets/79428895/82997c0c-82ba-4863-873f-bb7398a93908