hypertrons / hypertrons-crx

A browser extension for insights into GitHub projects and developers.
https://crx.hypertrons.io
Apache License 2.0
329 stars 91 forks source link

[Bug] Wrong metric data used in contributors chart. #820

Closed frank-zsy closed 1 month ago

frank-zsy commented 1 month ago

Version

1.9.6

Current Behavior

As implemented in https://github.com/hypertrons/hypertrons-crx/pull/794 , the data used right now is new_contributors, but we should use contributors metrics because the meaning of the chart just like participants, which is the active contributors in the repo but not new contributors.

Expected Behavior

Use contributors metrics instead of new_contributors

Environment

- OS: MacOS
- Browser: Chrome

Any additional comments?

No response

frank-zsy commented 1 month ago

Can use https://github.com/redis/redis to check the data, latest contributors count in the repo should 4 but not 0.

tyn1998 commented 1 month ago

Hello @Tenth-crew, could you handle this?

Tenth-crew commented 1 month ago

OK, I've made the changes. Previously, new_contributors was used because the Metric in opendigger's Readme did not list contributors but only new_contributors and Inactive contributors. I mistakenly thought that there were only these two metrics for contributors. If there is a complete metric somewhere, can you give me a link to check it out? In addition, maybe the metrics supported in the opendigger Readme can be updated later. 81ff2ad71ec2f30789e11871d9a3b5dd image

frank-zsy commented 1 month ago

@Tenth-crew Yes, this should be a missing metric in README since the metric is implemented recently. Will fix this soon.