search

hyperturtle / Stache

Trimmed mustache logic-less templates for python
MIT License
13 stars 8 forks source link

Python / Jython 2.2 support #1

Open clach04 opened 12 years ago

clach04 commented 12 years ago

Any interest in Jython 2.2 support? There are few holes but it mostly works.

I've also added 2.2 support to pystache, have you considered re-using (some of) the pystache test suite?

hyperturtle commented 12 years ago

Let me think about it for a while. are the change in _tokenize for pep8? or is that a jython 2.2/python 2.4 issue? Also for the tests, running pthong test.py is optional. If ran from nosetests, all tests are run even if one of them fails. Running test.py is just a convenience for me. I agree that the bool tests should be separate, the use case doesn't make much sense. I also like the itertools.takewhile fallback. Again, let me think about some of these changes and I'll try and incorporate some of these.

clach04 commented 12 years ago

All the changes are 2.4/2.2 related. The _tokenize() was for 2.4 (and earlier). I've not (yet) made an attempt on pep8 formatting changes, I was thinking about it (hence the comment in the commit for https://github.com/clach04/Stache/commit/25d633bc4687dff8fcf84905585860ad97839cc5 ) :-)

The last time I tried nose it didn't work with 2.2. I may have to see if it is worth getting that working under 2.2.