Fix various consistency issues and unnecessary failures

hyperupcall / autoenv

Directory-based environments.

MIT License

5.72k stars 261 forks source link

Fix various consistency issues and unnecessary failures #197

Closed hyperupcall closed 3 years ago

hyperupcall commented 3 years ago

more consistently prevent alias expansion across script
for cases in which alias expansion does not ensure consistent behavior 'command' builtin is used to prevent running user-defined functions rather than the intended builtins
create parent folder to authfile so touch command does not fail

Extra details embedded in the commit messages

inishchith commented 3 years ago

@eankeen Sorry for the delay - I've been in work commitments and missed this out somehow.

If you'd like to maintain the repository for further changes - do let me know.

hyperupcall commented 3 years ago

Thanks, I am interested in maintaining the repository; however, I would rather wait until I make more PRs so I know I can guarantee a commitment on my part

If you are able to review the changes, that is great, but if not, that is understandable. I can add/merge a test suite for the general usage of autoenv before merging this, just to be extra sure things don't break, if I end up receiving maintenance privileges

inishchith commented 3 years ago

Thanks, @eankeen! Sent an invite.

hyperupcall commented 3 years ago

Thank you, I did receive and accept the invite! And question, how do you wish to coordinate on releases? Publishing a 1.3.0 (which would supersede the 2012 v1.0.0 published in PyPi) ASAP would fix quite a few issues - I can make a PR to Homebrew, but the PyPi would have to be updated as well.

Aside: It looks like this PR got auto-closed because I was merging from my master branch, even though at the time, I created a tweak-commands branch. I re-created this pull request in #201