search

hyperwallet / php-sdk

An SDK implementation in PHP for the v4 REST APIs.
http://hyperwallet.github.io/php-sdk
MIT License
10 stars 31 forks source link

Support phpseclib V3 #132

Open fernandocoronatomf opened 2 months ago

fernandocoronatomf commented 2 months ago

Hey there,

We could really use some help getting phpseclib V3 support up and running—it's crucial for our application. I've tried updating the version in composer.json, but we're hitting a roadblock with the 'gree/jose' package, which hasn't been maintained in 8 years and remains a key dependency, even in HW SDK v4.

Do you have any plans to replace this package with a more maintained one like lcobucci/jwt? That would be a game-changer for us.

fernandocoronatomf commented 2 months ago

@grmeyer-hw-dev Can we maybe bring the gree/jose old not-maintaned package to inside hyperwallet/sdk so we can correct the namespaces? I think besides replacing the whole JWT package that would be an easier and quicker solution for now.

If I do the change would you merge it? I just need to make sure you're ok with it, we really need phpseclib v3

grmeyer-hw-dev commented 2 months ago

HI @fernandocoronatomf

I saw your Initial PR, and I tried to update too but it requires more change upgrade to phpseclib V3.

If I do the change would you merge it? Yes, just raise a PR, the goal is to get green on the GitHub Actions, and we can review and get your PR merged.

grmeyer-hw-dev commented 2 months ago

HI @fernandocoronatomf

Can we maybe bring the gree/jose old not-maintaned package to inside hyperwallet/sdk ? Short answer is no, We can't bring gree/Jose to the SDK for some reasons for reasons like:

But we can replace it for sure, Do you know any other option for gree/Jose ?

fernandocoronatomf commented 2 months ago

HI @fernandocoronatomf

Can we maybe bring the gree/jose old not-maintaned package to inside hyperwallet/sdk ? Short answer is no, We can't bring gree/Jose to the SDK for some reasons for reasons like:

  • Copy/rights or legal reasons
  • maintenance

But we can replace it for sure, Do you know any other option for gree/Jose ?

Hmm I actually raised an MR and all the checks passed. If you don't want to do that I guess because I brought the package inside the hyperwallet SDK, you could try using

firebase/php-jwt https://github.com/lcobucci/jwt

fernandocoronatomf commented 2 months ago

My PR https://github.com/hyperwallet/php-sdk/pull/133