Closed jkuhn1 closed 7 months ago
Fixed in #130
Release will be cut soon
Fixed in #130
Release will be cut soon
Actually #130 won't solve that particular issue for linux_x86_64
platform. If you look at https://github.com/hyperxpro/Brotli4j/blob/main/natives/linux-x86_64/pom.xml you'll see the javaModuleName
property is not correctly set:
<properties>
<javaModuleName>com.aayushatharva.brotli4j.linux.s390x</javaModuleName>
<javaModuleName>com.aayushatharva.brotli4j.linux.ppc64le</javaModuleName>
</properties>
instead of:
<properties>
<javaModuleName>com.aayushatharva.brotli4j.linux.x86_64</javaModuleName>
</properties>
This bug was introduced in #102
Describe the bug When upgrading brotli4j from 1.12.0 to 1.13.0 (and onwards) in a Java modular application the following error was reported:
I've compared
META-INF/versions/9/module-info.class
files:for native-linux-x86_64-1.12.0.jar:
from native-linux-x86_64-1.13.0.jar:
So it seems from 1.13.0, x86_64 jar contains module descriptor for ppc64le and since the exported ppc64le package does not exist in the Jar the module is corrupted and can't be loaded. I haven't checked for other architectures but maybe they are also impacted.
To Reproduce Create a Java modular application on linux x86_64 platform which uses brotli modules.
Expected behavior native-linux-x86_64-1.15.0.jar must contain module
com.aayushatharva.brotli4j.linux.x86_64
.ModuleFinder
can load modulecom.aayushatharva.brotli4j.linux.x86_64
from native-linux-x86_64-1.15.0.jarLogs If applicable, add logs to help explain your problem.
Platform (please complete the following information):
Additional context Add any other context about the problem here.