hyperxpro / Brotli4j

Brotli4j provides Brotli compression and decompression for Java.
Apache License 2.0
107 stars 35 forks source link

[BUG] `EncoderJNI.Operation` is not public, preventing the use of `EncoderJNI.push(Operation op, int length)` #144

Closed joakime closed 3 months ago

joakime commented 3 months ago

Describe the bug When attempting to integrate Brotli4J into Eclipse Jetty we found the following ...

To Reproduce Steps to reproduce the behavior:

  1. Write a testcase that uses EncoderJNI.Wrapper from a package that is not com.aayushatharva.brotli4j.encoder. (use com.aayushatharva.brotli4j.tests yourself)
  2. Attempt to use EncoderJNI.push(Operation op, int length)

Expected behavior The ability to use the public features of EncoderJNI.

Logs If applicable, add logs to help explain your problem.

Platform (please complete the following information):

hyperxpro commented 3 months ago

Makes sense. Would you like to do a PR to expose the APIs?

joakime commented 3 months ago

Makes sense. Would you like to do a PR to expose the APIs?

Done, opened PR #145