search

hyperxpro / Brotli4j

Brotli4j provides Brotli compression and decompression for Java.
Apache License 2.0
109 stars 36 forks source link

Support for LoongArch64 #76

Closed Panxuefeng-loongson closed 12 months ago

hyperxpro commented 1 year ago

Please ping me when it's ready for review. :)

Panxuefeng-loongson commented 1 year ago

RFR, thanks @hyperxpro

hyperxpro commented 1 year ago

You need to add a native module of LoongArch64 for the project to build. Also, update the CI workflow file for running tests.

Panxuefeng-loongson commented 1 year ago

You need to add a native module of LoongArch64 for the project to build. Also, update the CI workflow file for running tests.

I don't know if you have a loongarch machine, If there is no machine, does the CI workflow file not need to be modified?

hyperxpro commented 1 year ago

Use QEMU in Docker. :)

Panxuefeng-loongson commented 1 year ago

Use QEMU in Docker. :)

I'm not quite sure how to modify CI workflow, is it possible to merge this patch into the repo? You then make changes to the CI workflow file？

hyperxpro commented 1 year ago

Unfortunately, I can't merge until I have CI passing on this architecture.

Panxuefeng-loongson commented 1 year ago

I am not familiar with how to modify CI workflow, I may need your help. Thanks

hyperxpro commented 1 year ago

Alright, I will try this.

Panxuefeng-loongson commented 1 year ago

Alright, I will try this.

Thanks

hyperxpro commented 12 months ago

I'll close this as it's not feasible to add this atm.