search

hypery2k / cordova-hotspot-plugin

A Cordova plugin for managing HotSpot networks on Android
MIT License
37 stars 50 forks source link

Feature/fix permission issue #69

Closed dahomost closed 7 years ago

dahomost commented 7 years ago

Hi, Would you please check this out. Thank you

dahomost commented 7 years ago

@hypery2k Would you please review this code changes. thx

hypery2k commented 7 years ago

mmmh seems that the travis ci build isn’t working. I try to build a snapshot that people can install it and try it out. Not sure if it solves the problem really. Can’t remember right now if it’s really needed.

dahomost commented 7 years ago

You absolutely right, I updated the code 

                // With Android 6.0+/API level>= 23, user can turn on/off permissions as necessary.
                // Permissions are explicitely granted during the app runtime.
                if (Build.VERSION.SDK_INT < 23) {
                   // can't write Settings
                   callback.error("write settings: false");
                   return false;
                }
hypery2k commented 7 years ago

thanks for updating

dahomost commented 7 years ago

You're Welcome Sir. Thank you as well.