search

hypery2k / owncloud

In this repo you'll find apps and enhancements for owncloud
Other
156 stars 85 forks source link

Roundcube preview pane stays empty when selecting a message #176

Closed cdsim closed 10 years ago

cdsim commented 11 years ago

Okay so i updated my version to the last 1.2 commit ( 3a7afe60cb2eda126eff8186cc4d324c8ca73f53 ) and noticed that the message preview pane in roundcube stopped displaying the message, if i go to the address book screen and back to the mail screen for example, the preview pane start working as expected, but every time you enter roundcube the preview pane stays empty.

This issue started to appear at this commit 7113cbcb0d8de738a6c87b7d0b39e6ca9e135772 ( Fixing JS error )

cdsim commented 11 years ago

I probably should have mentioned that im running owncloud-5.0.12 with roundcube-0.9.4 on apache-2.4.6 and php-5.4.20.

hypery2k commented 11 years ago

for me it's working, the preview pane is working. I only have to open it via button click... for me it's working on rc0.7,rc0.8,rc.09

Can you provide an screenshot?

cdsim commented 11 years ago

Ok, can you try this : Inside roundcube, go to Settings / Preferences / Mailbox View - and check " Show preview pane " So now when you enter roundcube the preview pane is allready raised.

On my side, the first time i load roundcube from owncloud, i click on an email in the list and normally it should show the content inside the preview pane but the preview pane stays empty.

I have to either click the hide/raise button to show the content in the preview pane, click the roundcube logo on the upper right ( it refreshes the page ) or switch back and forth to a different screen (config/address book) and then the preview pane works as expected.

Can you tell me if you see the same behaviour ?

cdsim commented 11 years ago

Okay 5 screenshots : i open roundcube (show preview pane is enabled by default ), choose a folder and select the first mail, the next one and the one after, still nothing in the preview pane. rc01 rc02 rc03

Then i click hide the preview pane and raise it back up. rc04 rc05

And now the preview pane start showing up email content.

like i said on my side this issue started to appear at this commit 7113cbcb0d8de738a6c87b7d0b39e6ca9e135772

hypery2k commented 11 years ago

mmmh strange for me it's working. Did you clear you're browser cache?

cdsim commented 11 years ago

Yeah, i tried on firefox24 and ie10, same thing happens. I can't really help you more than this im not a php/js coder, maybe some other ppl can test this to confirm if it's my configuration or a real bug.

hypery2k commented 11 years ago

okay, seems an FF/IE think. Because i'm using, Chrome and Safari ;-)

hypery2k commented 11 years ago

really strange, because it's working in IE and FF: Can you please open the app in your environment, but before open the browser/javascript console and post the log here, see http://webmasters.stackexchange.com/questions/8525/how-to-open-the-javascript-console-in-different-browsers

mckaygerhard commented 11 years ago

i not have this problem with 1.1.19 but with 1.2 yes.. fail of me not grab javascript console output, but where a objet from wrong jquery version used depending roundcube version used, due i am busy right now cannot help but in 2 or 3 dais i please remenber me and i send to u debbugin of javascript console

cdsim commented 11 years ago

Okay here is the firefox (v24) console log, i uploaded it on pastebin (i dont know how github handle long log file in comments) and i also replaced the domain name by "mywebsite.com".

So the console log was cleared inside owncloud and then i clicked the roundcube icon. http://pastebin.com/bw1uM14V Im goin to install chrome on a windows7 computer and see if i get the same issue.

cdsim commented 11 years ago

Okay i can confirm that the preview pane works perfectly with the latest version of Chrome (v30). So the issue is only with Firefox and IE i guess ? I can get the console log for IE if you want.

mckaygerhard commented 11 years ago

could u post the log only from firefox, better if are v10 to v19!!

cdsim commented 11 years ago

Firefox v19.02 console log : http://pastebin.com/4m7E1pCS

o-bingo commented 10 years ago

same problem here but only from within owncloud (5.0.13): chrome is working fine, ff (tried 17 and 25.0.1) fails (all on linux)

roundcube 0.9.5, php 5.5.4, apache 2.2.25

mckaygerhard commented 10 years ago

please paste here , pastebin reports thats was removed!!! god daemon!

seems related to javascript interpretation... due chrome use webkit and mozilla not... please repaste HERE the log but also paste here the output of console errors of firefox (take care of only these url are loaded and cleared console output of firefox before )

cdsim commented 10 years ago

yeah i saw that, i posted the logfile here https://gist.github.com/c-simon/c536fead16340ce8c022#file-firefox_log

mckaygerhard commented 10 years ago

ileave a comment in the paste log..

i use iceweasel 9, iceweasel 10, and icecat 7:no problem, chromiun and webkit based browsers no problems, so then seems its a engine interpretation related to deprecated functions into jquery script... i hate that!!!!

rotdrop commented 10 years ago

Here is a fix. Kind regards,

Claus

https://github.com/rotdrop/owncloud/commit/b8409094c0f0d28113b07a33ac4c90fa31bc6be6

cdsim commented 10 years ago

YAY! it works. Rotdrop's commit fixed the previewpane here. Firefox 25 "Mozilla/5.0 (X11; Linux x86_64; rv:25.0) Gecko/20100101"

Cheers everyone.

mckaygerhard commented 10 years ago

@c-simon @hypery2k could confir if with that patch still works under chomre <= 17 and firefox 7 or firefox 10 or fierfox 17 ?

rotdrop commented 10 years ago

@mckaygerhard can't you simply try and see by yourself if it still works?

The problem seems indeed to be related to a different interpretation of the :visible attribute, around line 447 in most_recent_rc_release/program/js/app.js.src we find the following lines:

   // unset contentframe variable if preview_pane is enabled
    if (this.env.contentframe && !$('#' + this.env.contentframe).is(':visible'))
      this.env.contentframe = null;

Now, in recent firefox version the visible attribute inherit also the visibility of the parent elements, in this case most notably from the iframe, which is hidden at the start. I can confirm that recent web-kit based browsers still work with or without the patch. I was also able to compile firefox-17, but nothing older on my Gentoo system, and for me & firefox-17 the patch is needed. Also Chrome is only available in a recent version to me, i.e. v31-something.

Linux (recent Gentoo system) Browser NeedsPatch WorksWithPatch firefox-17 + + firefox-25 + + konqueror-4.11 - + chrom-31 - + opera-12.16 - +

WinXP 32bit in VirtualBox Browser NeedsPatch WorksWithPatch firefox-20 + + IE8 + +

Can check some OSX flavours by tomorrow. Just check yourself for your specific browser, please.

Kind regards,

Claus

mckaygerhard commented 10 years ago

i have a problem, i not have machine today, until few days.. due i'm on a remote env testing a daem,on.. on my work maybe on a week max i can test in a clean install

hypery2k commented 10 years ago

@rotdrop looks great.I've added you as collaborator. Feel free to push in you're changes

rotdrop commented 10 years ago

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

HI Martin,

I would also like to also move my "nocleartextpassword" branch AS A BRANCH to the main roundcube-ocapp repo, in order to keep things closer together. AS you gave me write permissions, I could do that by myself. Do you have any objections? I could remove my fork afterwards.

For the fix: I'll eventually push that particular fix, but probably not tonight; I'm busy with other things. Thanks for adding me as collaborator.

Best,

Claus

On 10.12.2013 08:04, Martin Reinhardt wrote:

@rotdrop https://github.com/rotdrop looks great.I've added you as collaborator. Feel free to push in you're changes

— Reply to this email directly or view it on GitHub https://github.com/hypery2k/owncloud/issues/176#issuecomment-30203877.

Claus-Justus Heine himself@claus-justus-heine.de

http://http://www.claus-justus-heine.de/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSp2cdAAoJEF8rbXubOwvKYT4QAJX9PnIlsyTMZEckDJTigmzp L/px7HukQArkvk5YCWfB78nj89N2fgd+ZgzZWlnHpHSysDPX5hv/PjYiOOfd0x9d sUMuSGaeTJz++OdNnlRUSsyR5D+rQ9C4l+PudLUNNv5PgfP42xki6z2zEQQu4KQY jIG39W9oOhXyzetEvZKUK3p6LX86wNy+moVE4KxUzRIA+StFuU7LkBFeAkPUuj1j BJKVbnLE3sa8nb/68pIsHznK3rX2ve9qE3kyAMeMgGQpoyXtvrGbMrqEFl8ci+BZ G0hdmfVxZN2dBAYgx73bnJjXbLi1dskOClt+YsyRJCtW/APpvt/jLFi4BDn9LA3/ gqCnZ7cc6Gp1Z3GMsKpNiDM2S8k+Br9h9EryB09g1XMsdK3UL7notAOJyR+ceFIq R0KzVLcklobVS6XfZX750OREVuhhLL8QmMIuM+dkMKuDycXxHKz3HG9Q+StwEgE6 NdnaRrrjW6USMw6tgGw1kQdc03iAEEKXIFNgHWPTaaxrxQCUvCtEemGpWpAuzHJn afVLsejKF/RE+RtQ9trY6Ptd72I+xa3ScUPKaPQd2+p7lm4HeS35ZOH2Ir3IXRpw BR2Dwto9bAiuYhkk/gab3a6He51IQqFI/ZPo+Onqf1e6nYhCs4jK7D7Xsqow7Ghj JCxkHDC4z/FEeucnSj3J =Y0cI -----END PGP SIGNATURE-----

hypery2k commented 10 years ago

feel free to push in. I will take a look at the changes during the beginning of next week

hypery2k commented 10 years ago

@rotdrop I've looked at your changes and I think we should move it to Release 2. It's an major refactoring and still some stuff is missing. We should push in you're changes after releasing 1.3.1

hypery2k commented 10 years ago

please retry latest master (version 2.0)

mckaygerhard commented 9 years ago

i confirm that this release tag v2.5.2.187 solve this issue.