Closed lexispike closed 3 years ago
Thanks for the fix, I just resolved some conflict and one small comment. :)
Can you kindly add two small gifs demoing the old and new way this behaves also to the PR description? Please let me know if you need any help
Will this PR be merged anytime soon? If the new preventSnapRefocus flag prevents the "weird" effect of changing the month when selecting the start date (ongoing issue 427), this will bring joy to many people.
https://jmp.sh/2leh8i8 GIF of example calendar with new options :)
Sorry for the delay on this, should be good to go!
Also, a before (or with preventSnapRefocus
disabled): https://jmp.sh/dkpptq0
after (with it enabled, a longer gif): https://jmp.sh/VoZMDET
Thank you for the contribution and addressing the comments! 🎉 I will try to cut a release today 🤞 :octocat:
(Also sorry for the delay in coming back to this, has been a busy 1-2 months 😓 , thank you for the patience)
Hi. Will there be a new npm version release applying these changes soon? Looking forward to it. Thanks.
Hey, sorry did not get a chance to do it last weekend. I plan to do this weekend, but if anyone would like to get involved, these are the changes needed: https://github.com/hypeserver/react-date-range/pull/497/files
Hey all, v1.4.0 is released ✨, please take a look and let us know if you see something out of place. Have a nice weekend!
Working great! Thanks @lexispike, thanks @kamyar.
You guys rock, this is something that has bugged me a lot
This is still an ongoing issue @kamyar. Please have a look at the the following scenario :
Expected outcome Stays on the next month.
Actual outcome: Jumps to the first month (even thought I am using alendarFocus={"backwards"} and preventSnapRefocus={true})
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyDescription
Add options to