search

hypeserver / react-date-range

A React component for choosing dates and date ranges.
MIT License
2.6k stars 679 forks source link

Update range selection behavior #492

Closed strada closed 3 years ago

strada commented 3 years ago

Types of changes

What types of changes does your code introduce?

Description

The user might want to move the start date without moving the end date, but the component is currently resetting the end date in all start date changes, which is not the ideal behavior in my opinion. See below a few gifs explaining the issue below:

How Google Analytics date selection behaves, (keeps end date selection): date-range-behavior-ga-1 date-range-behavior-ga-2

How the current component behaves when the start date is changed: date-range-behavior-rdr-1

After this PR: date-range-behavior-rdr-pr

We might want to bump at least minor version as this changes the behavior, in order to improve functionality.

Related Issue: https://github.com/hypeserver/react-date-range/issues/464

kamyar commented 3 years ago

Thanks for the PR @strada ! 🎉 Regarding the linked issue: Your Google Analytics example changed my mind.

What is your opinion regarding adding this behaviour behind a new config value similar to moveRangeOnFirstSelection? Something like retainEndDateOnFirstSelection (We can move these two booleans to an enum in a major release later )

I see the benefit of the new behaviour but I will vote for having the old behaviour retained by default but supporting this simpler approach with the flag so that we avoid breaking people implementation. Bumping the major is fine in my opinion but we are already planning a small cleanup that I personally would prefer to bump then and do a cleanup that makes your approach default.

Hiding the new behaviour behind a flag would help us get away with minor version bump + retain the old behaviour for people that prefer the resetting of endDate.

@burakcan @mkg0 @keremciu @onionhammer what do you folks think?