Closed n13 closed 2 years ago
Removed SDK
Keeping only 2 classes from the SKD, the web view runner - a wrapper for executing JS, very powerful, and the substrate network model.
Also rename polkawallet init to substrate_service since that's what it is
webViewRunner -> web_view_runner networkParams -> SubstrateChainModel txInfoData -> SubstrateTransactionModel polkawalletInit -> SubstrateService
This will allow us to remove all of the polkawallet sdk code - see next PR
That code has a lot of functions but it's so messy it does more harm than good.
We can keep it around to copy the JS invocations over, but we no longer have any dependencies on it.
🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
Removed SDK
Keeping only 2 classes from the SKD, the web view runner - a wrapper for executing JS, very powerful, and the substrate network model.
Also rename polkawallet init to substrate_service since that's what it is
webViewRunner -> web_view_runner networkParams -> SubstrateChainModel txInfoData -> SubstrateTransactionModel polkawalletInit -> SubstrateService
✅ Checklist
🕵️♂️ Notes for Code Reviewer
This will allow us to remove all of the polkawallet sdk code - see next PR
That code has a lot of functions but it's so messy it does more harm than good.
We can keep it around to copy the JS invocations over, but we no longer have any dependencies on it.
🙈 Screenshots
👯♀️ Paired with