hypha-dao / hashed-wallet

Hashed Wallet
MIT License
3 stars 3 forks source link

Recovery from disconnect #113

Closed n13 closed 2 years ago

n13 commented 2 years ago

Wifi disconnect with repeated disconnect states still not working

πŸ—ƒ Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

107

TBD

The main issue is that many calls into the JS evaluator do not return at all. So we end up waiting forever, and it stalls the restart process.

This is because of the original code not handling many cases; the code returns futures, and then console messages from JS complete these futures - but sometimes and for some classes of errors, the futures are never completed.

That's the issue - when a future is issued but never completed, code that "awaits" this future never finishes, causing all sorts of problems.

βœ… Checklist

πŸ•΅οΈβ€β™‚οΈ Notes for Code Reviewer

πŸ™ˆ Screenshots

For all UI changes

description 1 description 2
img1 img2

πŸ‘―β€β™€οΈ Paired with

@github-handle or "nobody" if you did not pair.

gguijarro-c-chwy commented 2 years ago

code looks good.

n13 commented 2 years ago

Let's merge it it has some improvements, can loop back to reconnect again later. Also it will help to see if it is actually reconnecting now.