Wifi disconnect with repeated disconnect states still not working
π Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
107
Added disconnect indicator on main screen
Added manual reconnect methods
Tested manual stop and start service - works well
TBD
[ ] recover from loss of network
The main issue is that many calls into the JS evaluator do not return at all. So we end up waiting forever, and it stalls the restart process.
This is because of the original code not handling many cases; the code returns futures, and then console messages from JS complete these futures - but sometimes and for some classes of errors, the futures are never completed.
That's the issue - when a future is issued but never completed, code that "awaits" this future never finishes, causing all sorts of problems.
β Checklist
[ ] Github issue details are up to date for people to QA.
Wifi disconnect with repeated disconnect states still not working
π Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
107
TBD
The main issue is that many calls into the JS evaluator do not return at all. So we end up waiting forever, and it stalls the restart process.
This is because of the original code not handling many cases; the code returns futures, and then console messages from JS complete these futures - but sometimes and for some classes of errors, the futures are never completed.
That's the issue - when a future is issued but never completed, code that "awaits" this future never finishes, causing all sorts of problems.
β Checklist
π΅οΈββοΈ Notes for Code Reviewer
π Screenshots
For all UI changes
π―ββοΈ Paired with
@github-handle or "nobody" if you did not pair.